search

mirage / ocaml-cohttp

An OCaml library for HTTP clients and servers using Lwt or Async
Other
713 stars 174 forks source link

Async exn: Cohttp_lwt__Connection.Retry while Cohttp_lwt_unix.Client.call (OCaml 5, cohttp --dev) #963

Open smondet opened 1 year ago

smondet commented 1 year ago

With today's master branch.

I have some code using Cohttp_lwt_unix.Client.call which works with OCaml 4.14.* and the released Cohttp.

On OCaml 5 it fails Cohttp_lwt__Connection.Retry, on a regular GET. Exception appears async (Shows up in the Lwt.async_exception_hook, cannot be caught).

Julow commented 1 year ago

I get this exception with Cohttp_lwt_unix.Client.get version 6.0.0~alpha1. I also observe the async behavior.

That it's defined in module Connection seems to indicate that it shouldn't leak through functions in module Client ?

mseri commented 1 year ago

Is the new alpha release still failing?