search

mirage / ocaml-conduit

Dereference URIs into communication channels for Async or Lwt
ISC License
84 stars 74 forks source link

continue #395 -- fix compilation in case of tls.dummy is used #404

Closed hannesm closed 2 years ago

hannesm commented 2 years ago

the PR #395 was partial - using tls.dummy.ml lead to compilation errors (since Lazy.force was used on a value ()).

//cc @CraigFe

Also, the ok_authenticator was removed -- for common operations client certificates are not required (so the tls_authenticator passed to server is by default None). This makes conduit compatible with recent X509 (& tls) releases 0.15.0 - but still maintain backwards compatibility.

the other change above -- tls 0.15.0 compatibility -- was merged into master and released independently of this PR.

hannesm commented 2 years ago

thanks, I figured the "use lazy for trust anchors" change hasn't been released at all, so I went ahead with the other change (adapt to tls 0.15.0) merged into the main branch, and released 4.0.2 with only that change. whoever is pushing for the lazy trust anchors, please do so and go ahead (I've no clue whether this impacts any API users / what version number should be assigned).

hannesm commented 2 years ago

part of #407