mirage / ocaml-crunch

Convert a filesystem into a static OCaml module
Other
73 stars 21 forks source link

Tentative fix for Cygwin #16

Closed samoht closed 8 years ago

samoht commented 8 years ago

A review would be appreciated, I don't remember if we need the full power of realpath or is this hack will just be as good for the use-case (i.e. get absolute path from an existing path). Might even be available in a better form in fpath

avsm commented 8 years ago

This should be fine. It's only used in the main command line wrapper to normalise the directory :+1:

let walker output mode dirs exts =
  let dirs = List.map realpath dirs in
avsm commented 8 years ago

Do we have a boilerplate Appveyor fragment to test this?

samoht commented 8 years ago

Maybe we should re-use the setup that @yallop created for ctype?

avsm commented 8 years ago

+1