mirage / ocaml-crunch

Convert a filesystem into a static OCaml module
Other
73 stars 21 forks source link

Port from oasis to topkg. #24

Closed fgimenez closed 8 years ago

fgimenez commented 8 years ago

Also includes an extended test for checking the actual functionality of crunched files and a .merlin file.

fgimenez commented 8 years ago

Hey @dbuenzli thank you so much for your review :)

Comments addressed, about the build dependency flag of ocamlfind, given the nature of the new test this package is also used while checking the crunched files functionality (compilation is required here), would it make sense to use {build & test} ?

I'm trying to reproduce the travis failure locally and will push the fix as soon as I sort it.

Cheers!

dbuenzli commented 8 years ago

would it make sense to use {build & test} ?

I guess so.

fgimenez commented 8 years ago

@dbuenzli done, and added the fixes to make travis happy, thanks! :)

hannesm commented 8 years ago

looks good to me! and travis is happy! \o/

fgimenez commented 8 years ago

hi @hannesm ! thanks a lot for your review :) fix pushed.

yomimono commented 8 years ago

This looks great! Thanks a ton for your work here, @fgimenez . :)