Closed fgimenez closed 8 years ago
Hey @dbuenzli thank you so much for your review :)
Comments addressed, about the build dependency flag of ocamlfind, given the nature of the new test this package is also used while checking the crunched files functionality (compilation is required here), would it make sense to use {build & test}
?
I'm trying to reproduce the travis failure locally and will push the fix as soon as I sort it.
Cheers!
would it make sense to use {build & test} ?
I guess so.
@dbuenzli done, and added the fixes to make travis happy, thanks! :)
looks good to me! and travis is happy! \o/
hi @hannesm ! thanks a lot for your review :) fix pushed.
This looks great! Thanks a ton for your work here, @fgimenez . :)
Also includes an extended test for checking the actual functionality of crunched files and a .merlin file.