search

mirage / ocaml-crunch

Convert a filesystem into a static OCaml module
Other
73 stars 21 forks source link

use dune watermark instead of 'dune-build-info' #56

Closed hannesm closed 2 years ago

hannesm commented 2 years ago

//cc @MisterDA @dinosaure -- would that be fine with you before a release?

hannesm commented 2 years ago

force-pushed after rebase onto master

samoht commented 2 years ago

Will that work for released archives? I'm not convinced it's a good change. What's the rationale?

hannesm commented 2 years ago

@samoht Yes, it works for released archives. In the release process, the watermark is substituted (dune subst invoked by dune-release).

The advantage is (a) fewer dependencies (b) consistency across repositories (see search for %%VERSION%% in org:mirage vs seach for Build_info.V1.version in org:mirage.