search

mirage / ocaml-crunch

Convert a filesystem into a static OCaml module
Other
74 stars 21 forks source link

file extension inclusion breakage, 3.2.0 -> 3.3.0 #61

Closed cemerick closed 2 years ago

cemerick commented 2 years ago

Using 3.2.0, using a file extension inclusion filter like -e md worked as expected; with 3.3.0, the leading dot must be included, i.e. -e .md.

The change isn't a huge deal, but isn't mentioned in the release notes, and does result in build breakage, requiring tweaking of the (typically) dune rules that invoke crunch.

hannesm commented 2 years ago

thanks for your report, we should really have a test case that shows the changed behaviour. amd eventually revert to the 3.2.0 semantics. @MisterDA any idea where the semantics changed and why?

hannesm commented 2 years ago

thanks, this is fixed in 3.3.1 (available soon in opam-repository)

hannesm commented 2 years ago

sorry for your inconvenience, at the same time I marked crunch 3.3.0 as unavailable in opam-repository, so once the 3.3.1 is merged users won't accidentally install 3.3.0. You can work around in CI / your opam packages by using as dependency: "crunch" {!= "3.3.0"} (which will either use 3.2.0 or the new 3.3.1).