search

mirage / ocaml-dns

OCaml implementation of the DNS protocol
BSD 2-Clause "Simplified" License
105 stars 43 forks source link

Use menhir parser #316

Closed RyanGibb closed 1 year ago

RyanGibb commented 2 years ago

Addresses https://github.com/mirage/ocaml-dns/issues/203

Work still needs to be done to improve error messages.

Dune is upgraded from 1.2 to 1.4 to support menhir 2.0 which gives nonterminal symbol type inference, fixing the error:

Error: the code back-end requires the type of every nonterminal symbol to be
known. Please specify the type of every symbol via %type declarations, or
enable type inference (look up --infer in the manual).
Type inference is automatically enabled when Menhir is used via Dune,
provided the dune-project file says (using menhir 2.0) or later.
hannesm commented 1 year ago

There are two issues: a conflict and a failing CI job. Are you interested in moving this further? If yes, please rebase and make the CI happy. If no, please close it. Thanks a lot.

RyanGibb commented 1 year ago

Closing for now as I don't have time to work in it. Thanks!