search

mirage / ocaml-fat

Read and write FAT format filesystems from OCaml
ISC License
26 stars 18 forks source link

Only require get_buf from IO_PAGE #37

Closed talex5 closed 9 years ago

talex5 commented 9 years ago

There's no need to ask for the whole interface when we only need one function. This should allow removing IO_PAGE from mirage-types.

See: https://github.com/mirage/mirage/pull/356

djs55 commented 9 years ago 
File "fat/impl.ml", line 20, characters 35-42:
Error: Signature mismatch:
       ...
       The field `get_buf' is required but not provided
Command exited with code 2.

Should this be get rather than get_buf?

talex5 commented 9 years ago

Probably needs to depend on `io-page >= 1.2'

talex5 commented 9 years ago

Added a missing opam update and Travis is happy now.

djs55 commented 9 years ago

Release 0.10.2 is at [ocaml/opam-repository#3494]

On Sat, Jan 31, 2015 at 6:50 PM, Thomas Leonard notifications@github.com wrote:

Added a missing opam update and Travis is happy now.

— Reply to this email directly or view it on GitHub https://github.com/mirage/ocaml-fat/pull/37#issuecomment-72330475.

Dave Scott