search

mirage / ocaml-fat

Read and write FAT format filesystems from OCaml
ISC License
26 stars 18 forks source link

fs.connect throws an exception when problems occur #57

Closed yomimono closed 7 years ago

yomimono commented 7 years ago

The patchset in #55 included an FS.connect which returns a (t, Block.error) result io. The mirage frontend tool expects invocations of connect to return a t directly or throw an exception, and so unikernels configured with this patchset couldn't build (see https://api.travis-ci.org/jobs/184038896/log.txt?deansi=true ).

There's an additional dependency on mirage-runtime to get pretty-printers for the block errors, so that the exception thrown during connect doesn't obscure useful details.

yomimono commented 7 years ago

(apologies for not noticing this in the original patch, @djs55!)

djs55 commented 7 years ago

Looks fine to me, and I think travis is happy (apart from 4.02 which is incompatible with functoria-runtime).