mirage / ocaml-fat

Read and write FAT format filesystems from OCaml
ISC License
26 stars 18 forks source link

fix inconsistent sector size between block and fs #81

Closed ehirdoy closed 4 years ago

ehirdoy commented 5 years ago

let page = alloc 4096 in seems to force read 4KiB but its unit should be FAT sector size.

This fixes "mirage-skeleton/device-usage/kv_ro", configured with hvt && --kv_ro=fat.

Signed-off-by: Hiroshi Doyu hiroshi.doyu@ericsson.com

hannesm commented 4 years ago

would someone with more knowledge than me about FAT (@avsm @djs55) be willing to review this? imho this looks fine and should be merged :)

samoht commented 4 years ago

Thanks!