search

mirage / ocaml-github

GitHub APIv3 OCaml bindings
ISC License
100 stars 61 forks source link

push events seem to contain `tree_id` and `id` instead of `sha` #137

Closed avsm closed 8 years ago

avsm commented 8 years ago

there is contradictory information about this in the github docs.. https://developer.github.com/v3/activity/events/types/#pushevent

the text describes sha but the example has id with the sha instead

closes #136

avsm commented 8 years ago

confirmed this PR fixes #136 with a datakitci deployment against live github

dsheets commented 8 years ago

Please test this against both the event query API and the web hook event push API -- they may have subtly different types.