search

mirage / ocaml-github

GitHub APIv3 OCaml bindings
ISC License
100 stars 61 forks source link

Add repository issue search #196

Closed avsm closed 6 years ago

avsm commented 7 years ago

This PR also includes a separate commit to improve error reporting (89f5eb63f3e973a54240c2260af939f3560c0208)

avsm commented 7 years ago

I will rebase this and address the review comments later...

samoht commented 7 years ago

I've force pushed to @avsm's branch with a rebase + a fix for all the points listed by @dsheets

samoht commented 7 years ago

I force pushed a new version with inheritance + fix in the timeline issue. And the milestone's repository field seems to have the right type, so all is good :-)

dsheets commented 7 years ago

Thanks! Just 2 small issues. Sorry for all the back-and-forth.

samoht commented 7 years ago

Ok I think this is good now :-) Thanks for the reviews!

samoht commented 6 years ago

It seems that all comments of @dsheets have been addressed so merging.