search

mirage / ocaml-github

GitHub APIv3 OCaml bindings
ISC License
100 stars 61 forks source link

Github is compatible with 1.0 #209

Closed rgrinberg closed 6 years ago

rgrinberg commented 6 years ago

But 0.99 is the minimum

cc @altgr @samoht @avsm

AltGr commented 6 years ago

Thanks a lot!

samoht commented 6 years ago

the revdeps are breaking:

#=== ERROR while installing github-hooks.0.2.0 ================================#
# opam-version         1.2.2 (aa258ecc06d3aea5a67f442a4ffd23f2a457180b)
# os                   linux
# command              jbuilder build -p github-hooks -j 4
# path                 /home/opam/.opam/4.04.2/build/github-hooks.0.2.0
# compiler             4.04.2
# exit-code            1
# env-file             /home/opam/.opam/4.04.2/build/github-hooks.0.2.0/github-hooks-1789-548b09.env
# stdout-file          /home/opam/.opam/4.04.2/build/github-hooks.0.2.0/github-hooks-1789-548b09.out
# stderr-file          /home/opam/.opam/4.04.2/build/github-hooks.0.2.0/github-hooks-1789-548b09.err
### stderr ###
# [...]
...
# File "src/core/github_hooks.ml", line 67, characters 16-33:
# Error: Unbound module Cohttp_lwt_body
samoht commented 6 years ago

Thanks! I will fix the issue with github-hooks separately.