Fix and enforce safe-string compatibility

mirage / ocaml-github

GitHub APIv3 OCaml bindings

ISC License

100 stars 61 forks source link

Fix and enforce safe-string compatibility #212

Closed kit-ty-kate closed 6 years ago

kit-ty-kate commented 6 years ago

ping @samoht

samoht commented 6 years ago

I am not sure why all the runs are testing all the revdeps, this seems a bit excessive to me... Would you mind removing that variable from the global section, changing a 4.04.2 test into a 4.06.0 and add the REVDEPS=true there? Thanks!

kit-ty-kate commented 6 years ago

Done. I used debian-stable and debian-testing for the revdeps, does that sound good ?

samoht commented 6 years ago

Not sure about the CI errors:

Command:
docker run --env-file=env.list -v /home/travis/build/mirage/ocaml-github:/repo local-build ci-opam
Unable to find image 'local-build:latest' locally
docker: Error response from daemon: pull access denied for local-build, repository does not exist or may require 'docker login'.
See 'docker run --help'.

but this looks like infra errors, so merging.