mirage / ocaml-github

GitHub APIv3 OCaml bindings
ISC License
100 stars 61 forks source link

Properly expose github-jsoo and add missing dependencies #216

Closed samoht closed 6 years ago

rgrinberg commented 6 years ago

Everything but the rename looks good. Shouldn't the module be Github_jsoo?

samoht commented 6 years ago

@rgrinberg I am trying to reflect what we do in github-lwt: I guess it's yet an other instance of the linking trick: github.mli is generated by the core lib and lwt as well as jsoo are implementing it for different backends.

rgrinberg commented 6 years ago

I see. So I guess this will need variants support to fully work.

avsm commented 6 years ago

varianttsssssssssssss