search

mirage / ocaml-github

GitHub APIv3 OCaml bindings
ISC License
100 stars 61 forks source link

WIP: Changes needed to support latest atdgen (json adapters) #218

Closed mjambon closed 5 years ago

mjambon commented 6 years ago

I removed some features from atdgen (tag_field, untyped) that were specific to how Github represents variants. I replaced them with a more generic mechanism, which simplifies atdgen's codebase and is more flexible. This new mechanism is called "json adapters". The idea is that when the structure of some json data doesn't match atdgen's conventions, the user can write a pair of functions that transform the json AST locally into a suitable form.

This branch should have everything it needs to work with json adapters (https://github.com/mjambon/atd/pull/72). make test was suspiciously short; what's a good way for me to test that it's all working?

mjambon commented 6 years ago

atdgen 2.0.0 is now available from opam-repository. The changes above are needed for ocaml-github to work with it.

avsm commented 5 years ago

Thanks for this, Martin! I'm going to merge this into master and test it from there. We don't have a comprehensive test suite, but ocaml-github is a fairly rapidly moving target anyway due to upstream changes, so any bugs will be apparent soon enough.