search

mirage / ocaml-github

GitHub APIv3 OCaml bindings
ISC License
100 stars 61 forks source link

Read passwords without lambda-term #238

Closed emillon closed 4 years ago

emillon commented 4 years ago

The binaries that github-unix ships can read passwords, though the library itself does not do it. This makes the github-unix -> lambda-term dependency a bit heavy.

This factors out this feature in a small private library that is based on the dune-release implementation:

https://github.com/ocamllabs/dune-release/blob/995bd1b3abc9ed54b1d9379f7046a23adb

On windows, the unix calls are noops so this probably displays the password.

Closes #237

cc @avsm

emillon commented 4 years ago

I refactored the CLI handling in a separate commit so that it represents the absence of password by None rather than an empty string but technically this is independent; we can leave this out if you prefer.

Aaylor commented 4 years ago

Looks good to me, thanks ! I have successfully created a new token with git-jar, without the password being echoed. Unfortunately, I have no windows machine on which I can try out this change :(

I'm ok with the change made on the parameter! :)