mirage / ocaml-github

GitHub APIv3 OCaml bindings
ISC License
100 stars 61 forks source link

Fix authentification of effectful (POST/PATCH/PUT) requests. #242

Closed Aaylor closed 3 years ago

Aaylor commented 3 years ago

Effectful requests did not pass the [token] to the [realize_header], leading the request to be sent unauthentified.

The issue was reported in multiple issues in opam-publish:

Tested by using lib_test/create_pull.ml (with custom value), but also with some part of opam-publish sources (by generating a token, and by creating a custom PR)