mirage / ocaml-github

GitHub APIv3 OCaml bindings
ISC License
100 stars 61 forks source link

Tidy up dune files #247

Closed emillon closed 3 years ago

emillon commented 3 years ago

In the spirit of #246:

There was a link to an old dune issue but it seems that these were hiding some problems.

To the best of my knowledge, it is best practice to let dune deal with flags.

Small improvements by using shortcuts allowed by dune.

tmcgilchrist commented 3 years ago

Looks good to me, just failing on the 4.12 builds as expected.

avsm commented 3 years ago

Thanks!