Split data handling in its own package

mirage / ocaml-github

GitHub APIv3 OCaml bindings

ISC License

100 stars 61 forks source link

Closed emillon closed 3 years ago

emillon commented 3 years ago

This exposes a dependency-light package for users that interact with the Github API through an HTTP client that is not cohttp (for example curly).

avsm commented 3 years ago

This looks good to me. What's left to turn it ready for review/merge?

emillon commented 3 years ago

@avsm I rebased it and it's now ready.

emillon commented 3 years ago

Re. 4.12 failures. Does the following plan make sense:

locally disable the warning (so that we get meaningful CI)
file an issue with 5.0.0 milestone documenting how to fix this
when it's time to release 5.0.0, add a breaking change with a unit argument, and remove the warning override

emillon commented 3 years ago

Ah nevermind it's not public API. I'll open a PR for this.

avsm commented 3 years ago

Thanks!