Closed dra27 closed 3 years ago
there is a different fix in #253 from @tmcgilchrist https://github.com/mirage/ocaml-github/pull/253/files#diff-48784b347e44c40808a18a58ea10c171458783388aec421be3979cda23704edeL472
Hah! That was my first attempt... up to you which version is wanted 🙂
Either or, aesthetically I prefer the string option
but the compatibility argument is 👌🏻
I'd go for the "accurate types" with the option
and just fix up users. What's the point in having static types if we don't use them :-)
Doing as a standalone PR here https://github.com/mirage/ocaml-github/pull/256
The label field can be
null
. For compatibility, I've defaulted that to""
rather than changing the type.Apparently
null
is used with theghost
user: