search

mirage / ocaml-rpc

Light library to deal with RPCs in OCaml
ISC License
96 stars 31 forks source link

Remove duplication in .mlis, expose MarshalError, add docs #115

Closed gaborigloi closed 6 years ago

gaborigloi commented 6 years ago

Fixes #87

Signed-off-by: Gabor Igloi gabor.igloi@citrix.com

gaborigloi commented 6 years ago

We should also deduplicate the implementations themselves at one point, but that will be much harder.

gaborigloi commented 6 years ago

It would also be nice to upload the docs automatically somewhere.

mseri commented 6 years ago

I agree on both comments :)

mseri commented 6 years ago

I think we could use the associated github pages for the documentation

mseri commented 6 years ago

Tomorrow I’ll play with dune-release and do a deserved upstream release and announce

gaborigloi commented 6 years ago

Thanks for the review, fixed the issues. That sounds great, thanks! I was wondering, should we split out more opam packages first, to avoid having a second breaking release afterwards? Because if we do #101 then we'll introduce the angstrom dependency (probably, if there isn't an ocamldoc parser already available), and then it'd be nice to add this extra dependency to a separate opam package, instead of making rpclib heavier.

mseri commented 6 years ago

I am still not sure ablut parsing ocamldoc by hands though

mseri commented 6 years ago

And I think it would be a minimal disruption anyways

mseri commented 6 years ago

I was starting to set-up the auto push but I don’t have enough privileges to setup github pages. @jonludlam can you increase my privileges or do it for us?