search

mirage / ocaml-rpc

Light library to deal with RPCs in OCaml
ISC License
96 stars 31 forks source link

Add Base64 #154

Closed CGenie closed 4 years ago

CGenie commented 4 years ago

Closes #152

mseri commented 4 years ago

Thank you very much!

mseri commented 4 years ago

I think also the ppxs need to be updated, am I wrong?

CGenie commented 4 years ago

@mseri Thank you for your comments, I updated the code. About ppxs, I'm not sure where to add this. So far I just added this: https://github.com/mirage/ocaml-rpc/pull/154/files#diff-36b922328d60097472c823ecbc21c056R15

mseri commented 4 years ago

Just a small change and it's good to merge imo

mseri commented 4 years ago

Thanks! I'll wait for Travis and merge