search

mirage / ocaml-tar

Pure OCaml library to read and write tar files
ISC License
54 stars 34 forks source link

Add failing tests #100

Closed reynir closed 1 year ago

reynir commented 1 year ago

There's a corner case if sector size is greater than 512 where writes will fail with Invalid_argument from Cstruct.blit.

hannesm commented 1 year ago

this looks very fine to me, thanks for the failing tests and the fixes :)

hannesm commented 1 year ago

to me this looks ready to be merged + a release being cut. what do you think?

reynir commented 1 year ago

Yes, I agree. I will cut a release today.