Brushup - Githubissues

reynir commented 1 year ago

This is a bit of a code dump from a review I did before Christmas. Mostly it's refactorings and updates to newer upstream APIs. Notable changes is:

Document exceptions and behavior
Fix ustar version serialization - the version was serialized as 0\000 instead of 00. Unmarshalling is more strict, but I am unsure if this is desirable.
Fix GNU LongName/LongLink (need a revisit by me)

This is work-in-progress. The commit history is a mess, and likely I will cherry-pick the changes I like or do a squash merge in the end.

hannesm commented 1 year ago

rebased on top of main and force-pushed

hannesm commented 1 year ago

looks fine to me, apart from minor remarks

reynir commented 1 year ago

This PR tried to do too much while being half-finished. Parts of its fixes has been merged by now.

mirage / ocaml-tar