mirage / ocaml-uri

RFC3986 URI parsing library for OCaml
Other
97 stars 57 forks source link

Optional sexplib #121

Closed Julow closed 5 years ago

Julow commented 6 years ago

Make sexplib optional by moving sexp conversions to the uri.sexp library

Sexp conversions are reimplemented with different internal types, compatibility is broken

Deriving sexp added a lot of dependencies that were problematic in my used case (js_of_ocaml)

avsm commented 6 years ago

Thanks for the PR! I'm ok with this, but we need to analyse the downstream user fallout to avoid splitting the opam universe.