search

mirage / ocaml-uri

RFC3986 URI parsing library for OCaml
Other
98 stars 57 forks source link

Add RFC6874 compliance for IPv6 litteral with zones, fix #47 #48

Closed vbmithr closed 10 years ago

avsm commented 10 years ago

Thanks -- would you be able to push a test case as well?

vbmithr commented 10 years ago

ping ? Can someone review this tiny patch ?

dsheets commented 10 years ago

This looks OK to me. I am a bit disappointed by the escaping of the square brackets and the IPv6 address segment separators. We should have normalizing behavior in this case and we don't because we don't distinguish hostnames from addresses at the serialization phase.

I think we should merge this (and my tiny new test case PR #49) and make a point release. If I find a few spare hours this weekend/next week, I'll add IPv6 zone idents (mirage/ocaml-ipaddr#13) to ipaddr and then plumb it into uri.

avsm commented 10 years ago

Merging and releasing the point release