search

mirage / ocaml-uri

RFC3986 URI parsing library for OCaml
Other
98 stars 57 forks source link

Setting password to None in URI without password adds '@' #78

Closed hcarty closed 9 years ago

hcarty commented 9 years ago

Example:

let uri = Uri.of_string "http://example.com/" in
Uri.with_password uri None
|> Uri.to_string

gives http://@example.com/

dsheets commented 9 years ago

That's indeed surprising behavior. I've fixed it in 5c6210a. I'm not sure what I was thinking when I wrote that test...

hcarty commented 9 years ago

Thanks for the quick fix!

dsheets commented 9 years ago

Now published by ocaml/opam-repository#4326 as uri.1.9.1.