search

mirage / ocaml-vchan

Pure OCaml implementation of the "vchan" shared-memory communication protocol
ISC License
45 stars 26 forks source link

Restore compatibility with cstruct.2.4.1 #106

Closed djs55 closed 6 years ago

djs55 commented 7 years ago

The findlib package cstruct.ppx is preferred to ppx_cstruct since it should work with both cstruct.2.4.1 and cstruct.3.0.0

Related to https://github.com/ocaml/opam-repository/pull/9455

djs55 commented 7 years ago

Hm, this seems to break under cstruct.3.0.0:

(cd _build/default && ./.ppx/ppx_sexp_conv+cstruct.ppx/ppx.exe -no-check --dump-ast --cookie 'library-name="vchan"' -o lib/endpoint.pp.ml --impl lib/endpoint.ml)
File "lib/endpoint.ml", line 96, characters 12-19:
Error: ppx_type_conv: 'sexp_of' is not a supported type type-conv generator
djs55 commented 7 years ago

This only builds if I pin https://github.com/mirage/ocaml-cstruct/pull/151

yomimono commented 6 years ago

@djs55 I'm going to close this since it conflicts with the current jbuild - please feel free to reopen if you're still working on this.