CA-218219: precheck index range before accessing

mirage / ocaml-vhd

Read and write .vhd format data

Other

9 stars 20 forks source link

CA-218219: precheck index range before accessing #36

Closed zli closed 8 years ago

zli commented 8 years ago

This is similar to the CA-139732 case fixed previously, just a different occurence. Basically, when there is a chain of VHDs of different sizes (i.e. there was resize operation in history), we'd better check if the index is in range before accessing the data.

Signed-off-by: Zheng Li zheng.li3@citrix.com

djs55 commented 8 years ago

The CI seems generally broken:

=-=- Processing actions -=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
∗  installed conf-m4.1
∗  installed ocamlfind.1.6.2
Done.
+ocamlc.opt yorick.mli
+ocamlfind ocamlc -c yorick.ml
+ocamlfind ocamlc -o ci-opam -package unix -linkpkg yorick.cmo ci_opam.ml
+cd -
/home/travis/build/djs55/ocaml-vhd
+/tmp/tmp.NmTGU2pd2n/ci-opam
Fatal error: exception Failure("No opam file found, aborting.")

This patch looks good to me though!

euanh commented 8 years ago

@djs55 Assuming you are not expecting any more changes soon, could you please make a new release with this fix?