Update to Mirage 3 - Githubissues

mirage / ocaml-vhd

Read and write .vhd format data

Other

9 stars 20 forks source link

Update to Mirage 3 #45

Closed gaborigloi closed 7 years ago

gaborigloi commented 7 years ago

Update lib/block.ml to match the new Mirage_types_lwt.BLOCK interface
Move from the polymorphic variant result type to the standard result type, and use the rresult result combinator library

gaborigloi commented 7 years ago

Should we do the jbuilder port in this PR or a subsequent one? Maybe it's best to split them up, because the Travis build is finally passing :smile:

mseri commented 7 years ago

Fair enough. Let’s hear what the maintainers prefer

mseri commented 7 years ago

Ping @yomimono

yomimono commented 7 years ago

I don't really know much about this package, but the port to Mirage 3 looks reasonable to me. I think the real experts on this repository are @djs55 and @avsm , but if they don't have time to review in the next couple of days I'm happy to merge.

Jbuilder port in a separate PR would be great :)

mseri commented 7 years ago

🎉 Thanks! Time for the jbuilder port now :)

djs55 commented 7 years ago

@yomimono thanks for the review and merge! Sorry I didn't respond to the ping :(

gaborigloi commented 7 years ago

We've ported the lib to jbuilder with @mseri , PR is https://github.com/mirage/ocaml-vhd/pull/46