search

mirage / ocaml-vhd

Read and write .vhd format data
Other
9 stars 20 forks source link

Port to jbuilder #46

Closed gaborigloi closed 6 years ago

gaborigloi commented 7 years ago

This commit splits the original OPAM package into two, corresponding to the two ocamlfind libraries with the same names: vhd and vhd-lwt.

Also, I've removed the Output module from the core library that wasn't used by any of the packages depending on this, and I've removed the unused shadowed descr_of_operation function from lib/patterns.ml.

Signed-off-by: Gabor Igloi gabor.igloi@citrix.com

mseri commented 7 years ago

Renaming the library vhd introduces the quirck that now to get to the actual Vhd module, you have Vhd.F.Vhd, so if you open Vhd and then open F you actually overwrite the library namespace...

I'd rather keep the library name as Vhd_format and have the internal naming a bit more consistent and less overwrite prone. What do you think? @djs55 @yomimono

yomimono commented 7 years ago

I have no opinion based in knowledge of the package but your preference seems sensible, @mseri.

yomimono commented 7 years ago

I was tagged in here but don't really feel confident reviewing/merging; perhaps @avsm or @djs55?

gaborigloi commented 6 years ago

Thanks, this means we can release it now :smile: