Fix string escaping in code generator

mirage / ocaml-vhd

Read and write .vhd format data

Other

9 stars 20 forks source link

Fix string escaping in code generator #56

Closed lindig closed 6 years ago

lindig commented 6 years ago

The OCaml code emitted by Disk.print_ocaml is missing a String.escape that was lost when the code was moved to use Bytes to make it safe-string compliant. See commit

7d96f3d9f9da2401884c6ebc1c2e984715719ca5

Signed-off-by: Christian Lindig christian.lindig@citrix.com

djs55 commented 6 years ago

@lindig @edwintorok this also looks good to me, thanks!

I've made you both collaborators on this repo so you can review and merge fixes yourself. Let me know if anyone else should be added (@jonludlam is already on the list)