Compatibility with cstruct 6.0.0, drop dependency on ounit

psafont commented 3 years ago

This includes the minimal change to make it compatible with both older cstructs as well as 6.0.0.

Looking ahead this could be changed to Cstruct.to_string ~off:0 ~len:13 buffer and all the .len replaced with .length, but that makes it not compatible with older versions.

The patterns module is only used for testing, I've moved it to the tests library. This allows dropping ounit from the package when it's not being tested.

The dependency constraints for mirage have been pulled from opam-repository. They will be tackled at some point.

Travis testing has been changed so all versions of ocaml are tested, and the package has been changed to vhd-format-lwt to force running the tests. This tests the building of both opam packages without making the amount of jobs to explode.

psafont commented 3 years ago

Not sure what the ci failure is about:

#=== ERROR while compiling topkg.1.0.3 ========================================#

# context              2.0.8 | linux/x86_64 | ocaml-base-compiler.4.04.2 | file:///home/opam/opam-repository
...
# + ocamlfind ocamlc -where > /home/opam/.opam/4.04/.opam-switch/build/topkg.1.0.3/_build/ocamlc.where
# ocamlfind: Package `threads' not found
# Command exited with code 2.

psafont commented 3 years ago

Builds are failing for ocaml 4.04 because dune 2.8.5 is used, which doesn't support ocaml < 4.08. Might be because of the ubuntu image.

dinosaure commented 3 years ago

I allowed OCaml-CI to this project, we will see complaints from it if we have some 👍 .

psafont commented 3 years ago

Might be worth dropping travis, seeing it's so unreliable and we have ocaml-ci now.

dinosaure commented 3 years ago

Yes, I will delete it in another PR, thanks for the PR. Do you want a release?

psafont commented 3 years ago

That'd be great, thanks!

dinosaure commented 3 years ago

Thanks for this upgrade 👍 .

mirage / ocaml-vhd

Compatibility with cstruct 6.0.0, drop dependency on ounit #67