mirage / prometheus

OCaml library for reporting metrics to a Prometheus server
Apache License 2.0
49 stars 27 forks source link

Make help / type information be OpenMetrics compatible #47

Closed Nymphium closed 2 years ago

Nymphium commented 2 years ago

Prometheus may define the format of help and type information as "#" ("HELP" | "TYPE") ... whereas OpenMetrics defines as "#" SP ("HELP" | "TYPE") .... In the former text the definition has ambiguousness what is "token", and the current implementation chooses no space between "#" and "HELP"/"TYPE". However, for example, datadog agent assumes there should have space between the first character "#" and the following "HELP"/"TYPE".

This PR adds space to split into tokens.