mirage / qubes-mirage-firewall

A Mirage firewall VM for QubesOS
BSD 2-Clause "Simplified" License
211 stars 28 forks source link

Remove dummy kernel files #70

Closed talex5 closed 7 months ago

talex5 commented 5 years ago

The mirage-firewall distribution includes dummy modules.img and initramfs files. These were needed on Qubes 3 for it to accept something as a kernel.

On Qubes 4 (according to https://www.qubes-os.org/doc/managing-vm-kernel/):

All the files besides vmlinuz are optional.

We should remove these dummy files from the build and installation instructions.

marmot1791 commented 4 years ago

As of today on Qubes R4.0 with all updates dom0 still requires the dummy initramfs to start a mirage qube, but modules.img is not required.

marmot1791 commented 4 years ago

Opened question of whether this is a bug or a docs issue over at qubes-issues: https://github.com/QubesOS/qubes-issues/issues/5516

marmot1791 commented 4 years ago

This is partially blocked until Qubes R4.1. Until that is released initramfs is still required.

hannesm commented 2 years ago

Since Qubes 4.0 is end of life now, IMHO it would be good to remove the initramfs file. This also means that our packaging and install instructions can be much simpler (we'll only distribute a single binary, and no need for tar).

Does this make sense @palainp?

palainp commented 2 years ago

This should be right according to the documentation, but I was unable to boot without it some times algo :/

palainp commented 2 years ago

This is still the case, I have the following:

$ qvm-start mirage-fw
Missing file: /var/lib/qubes/vm-kernels/mirage-fw/initramfs
palainp commented 2 years ago

The existence of initramfs is checked in https://github.com/QubesOS/qubes-core-admin/blob/c177aacbe1afc35034826ef538c0e49ed40b6bc7/qubes/storage/kernels.py#L140 See: https://github.com/QubesOS/qubes-issues/issues/5516

hannesm commented 2 years ago

Thanks @palainp for your investigations :)

palainp commented 7 months ago

https://github.com/QubesOS/qubes-issues/issues/5516 has been resolved now. This will works with the next Qubes update, and we can remove that dummy file for the next release :)

palainp commented 6 months ago

With dom0 updated we can remove initramfs (https://github.com/QubesOS/qubes-core-admin/pull/586). The PR in documentation is pending: https://github.com/QubesOS/qubes-doc/pull/1402 We can release only vmlinuz and a hashsum file now :)