mirageruler / df-frontend-2023

learning FE stuffs from dwarves
https://df-frontend-2023-rust.vercel.app
0 stars 1 forks source link

Submission for assignment 4 #4

Open mirageruler opened 11 months ago

mirageruler commented 11 months ago
tienan92it commented 11 months ago

Hello @mirageruler , well done!. Below is some feedback for your assignment.

Requirements

Final result: ✅ passed 90% of requirements

Feedback

  1. Redirect to 404 page if bookId isn't existed to avoid app crashing. https://github.com/mirageruler/df-frontend-2023/blob/c96393cbf7725e94c691419e6e6c0a7eddb7e32b/assignment-4/src/app/book/%5Bid%5D/page.tsx#L13-L16

  2. Also sync pagination and search term with URL state. Like ?page=&s=.