search

mirah / pindah

Tools for building Android applications with Mirah
Apache License 2.0
228 stars 27 forks source link

Failed tasks do not stop the build process. #7

Closed technomancy closed 12 years ago

technomancy commented 13 years ago

Compilation errors in the mirahc stage will still cause the app (whatever version is already on disk) to be installed in "jrake install"

(This is true only when the compiler is invoked using the org.mirah.ant.Compile task; shelling out with exec works properly.)

abscondment commented 13 years ago

What's the rationale for calling the ant.Compile task rather than using exec? This is a pretty frustrating bug, especially when you get in the habit of running rake install && adb logcat.

technomancy commented 13 years ago

I believe exec will spawn another JVM, so you pay startup costs for the redundant process.

abscondment commented 13 years ago

That makes sense. I submitted a fix on the mirah side of things; think you can test it out?

https://github.com/mirah/mirah/pull/140

abscondment commented 12 years ago

This is stale; the issue was fixed by mirah/mirah#140.