search

miraisolutions / SmaRP

Shiny app for projecting retirement funds / benefits
https://mirai-solutions.ch/gallery/smarp
20 stars 9 forks source link

remove emails of people that left Mirai #155

Closed Chargothrond closed 2 years ago

Chargothrond commented 2 years ago

Do not merge before February.

We still need to define a new person to receive the "cre" role. Should we just add @riccardoporreca as the only person left with an email or someone else? What do you think @RolandASc ?

Another open point is how to bring this to master: I don't think it makes sense to create a new release for this, but we need to update the DESCRIPTION file there as well eventually. Someone with admin access could also change the default branch to "develop", which would anyway be the expectation for the GitFlow approach.

Chargothrond commented 2 years ago

@riccardoporreca @RolandASc , this is now ready for review since it is February. Tbd if we just also merge the branch into master to get the updates on both develop and master.

RolandASc commented 2 years ago

I wouldn't mind switching the default branch to develop, but we'd have to update the README accordingly and should check any implications on the CI.