miralbhalani / opendatakit

Automatically exported from code.google.com/p/opendatakit
0 stars 0 forks source link

GeoPointActivity does not fall back to GPS in Collect v1.1.7-beta1 #226

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
GeoPointActivity will not use the GPS location provider; the request to the 
network provider overrides the previous request to GPS.  The attached patch 
against this changeset fixes this bug.

This issue was encountered in Collect v1.1.7-beta1 running on Android 2.2.

Original issue reported on code.google.com by matt.ad...@radicaldynamic.com on 7 Jun 2011 at 7:36

Attachments:

GoogleCodeExporter commented 9 years ago
This patch should be applied against f85cab690aa8 - Cheers, Matt

Original comment by matt.ad...@radicaldynamic.com on 7 Jun 2011 at 7:36

GoogleCodeExporter commented 9 years ago

Original comment by wbrune...@gmail.com on 7 Jun 2011 at 9:45

GoogleCodeExporter commented 9 years ago
Actually, the second request does not override the first.  "You can also 
request location updates from both the GPS and the Network Location Provider by 
calling requestLocationUpdates() twice—once for NETWORK_PROVIDER and once for 
GPS_PROVIDER." 
From:  
http://developer.android.com/guide/topics/location/obtaining-user-location.html

There was another issue in both geo-activities that if either provider was 
disabled, then neither would get used.  I fixed the activities so that none, 
either, or both of GPS and Network are used depending on what the user has 
selected in their phone's location settings.

Original comment by carlhart...@gmail.com on 10 Jun 2011 at 3:26