miralbhalani / opendatakit

Automatically exported from code.google.com/p/opendatakit
0 stars 0 forks source link

repeat count and noaddremove #247

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
pretty sure this is a javarosa bug 
(https://bitbucket.org/javarosa/javarosa/issue/4/nested-repeat-ignores-jr-count)
 but we need to track it as well. 

according to the spec at http://code.dimagi.com/JavaRosa/wiki/xform we should 
be able to have a fixed or constrained number of repeats. we should also be 
able to bypass the add/remove dialog. this is a long standing bug that should 
be fixed.

i've attached a form that doesn't work.

Original issue reported on code.google.com by yanokwa on 29 Jun 2011 at 7:03

Attachments:

GoogleCodeExporter commented 9 years ago
"the first condition works for me. the second condition (counting the nodeset) 
does not, but that's because the engine doesn't honor constraint conditions on 
groups"
-- clayton. 

i propose we fix the first condition in collect and ignore the second condition.

Original comment by yanokwa on 29 Jun 2011 at 7:29

GoogleCodeExporter commented 9 years ago
looks like the problem is in the core. i've used version 97b0fe68d200 and the 
controller is handing out the wrong event.

swipe to first question
I/System.out(18030): current event EVENT_BEGINNING_OF_FORM
I/System.out(18030): next event EVENT_REPEAT
I/System.out(18030): next event EVENT_QUESTION

swipe to next question
I/System.out(18030): current event EVENT_QUESTION
I/System.out(18030): next event EVENT_REPEAT
I/System.out(18030): next event EVENT_QUESTION

swipe to next question, dialog pops up
I/System.out(18030): current event EVENT_QUESTION
I/System.out(18030): next event EVENT_PROMPT_NEW_REPEAT

Original comment by yanokwa on 30 Jun 2011 at 4:47

GoogleCodeExporter commented 9 years ago

Original comment by yanokwa on 30 Jun 2011 at 9:26

GoogleCodeExporter commented 9 years ago
this has been fixed in the core. carl, if you pull the latest changes for the 
next beta, it'll work.

Original comment by yanokwa on 30 Jun 2011 at 9:27

GoogleCodeExporter commented 9 years ago
there is a slight bug with jr ignoring the noAddRemove value. i've reopened 
until it's fixed.

Original comment by yanokwa on 30 Jun 2011 at 9:39

GoogleCodeExporter commented 9 years ago
we'l be ignoring noaddremove from this point forth.

Original comment by yanokwa on 1 Jul 2011 at 11:22

GoogleCodeExporter commented 9 years ago
"The noAddRemove flag should work, I've been using it fairly regularly (there 
may be an upstream problem, here)."
-- clayton

Original comment by yanokwa on 1 Nov 2011 at 8:53

GoogleCodeExporter commented 9 years ago

Original comment by yanokwa on 23 Mar 2012 at 7:59

Attachments: