Closed pl0xz0rz closed 2 years ago
Test looks OK:
-- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html
----------------------------------------------------------------------------------------------- JSON report ------------------------------------------------------------------------------------------------
report saved to: test6.json
========================================================================================= short test summary info ==========================================================================================
FAILED test_bokehDrawSA.py::testBokehDrawArraySA_tree - TypeError: can only concatenate list (not "str") to list
=========================================================================== 1 failed, 36 passed, 7 warnings in 293.01s (0:04:53) ===========================================================================
Real use case test - https://gitlab.cern.ch/alice-tpc-offline/alice-tpc-notes/-/blob/master/JIRA/ATO-595/analyzeVertexerMC.C nPoints=500000 timing is OK: (for standard histogramming as before for parameterized significantly better)
Using index took 10.399999976158142 milliseconds.
VM5143:112 Filtering took 199.20000004768372 milliseconds.
VM5143:127 Histogramming took 120.89999997615814 milliseconds.
VM5143:129 454871
Hello. Could you please explain in the first message - why this new feature was implemented (parameterized aliases) and point to the code segment -where this javascript dependency tree was implemented
This PR:
fixes a bug where selections for multi-selects are invalidated when an unrelated derived column change - bokehTools.py - the bug was introduced in #212
Adds a simple dependency tree for derived columns on the client, optimizing recomputing them as a side effect by saving some garbage collection time - CDSAlias.ts - this should also make derived columns update properly when dependencies are changed, preparation for making the text input widgets as discussed in ATO-595
Fix problem with suboptimal performance of parametric aliases - reported in ALICE fastCombinator tracking use case