miranov25 / RootInteractive

5 stars 12 forks source link

Optimized bokehDrawSA by removing dead code (factor ~ 2) #268

Closed pl0xz0rz closed 1 year ago

pl0xz0rz commented 1 year ago

Relates to #262

This should improve the performance, in test_UnbinnedQuantile it improved the time from 33 seconds to 15 seconds. Bottlenecks still seem to be validation, compiling typescript and compression.

miranov25 commented 1 year ago

-- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html --------------------------------------------------------------------------------------- JSON report --------------------------------------------------------------------------------------- report saved to: test6.json ======================================================================== 37 passed, 7 warnings in 68.98s (0:01:08) ========================================================================

miranov25 commented 1 year ago

Real use case with old version:

Compress factor 822674 12005158 0.06852671160179649 60 isPrimMIP.factor()
Compress _all 455870323 3736594020 0.12200156628201209 60
CPU times: user 4min 26s, sys: 14.3 s, total: 4min 40s
Wall time: 5min 11s
miranov25 commented 1 year ago

Real use case new version:

Compress factor 821710 12001458 0.0684675145303179 60 isPrimMIP.factor()
Compress _all 455722711 3735442395 0.12199966237198526 60
CPU times: user 2min 16s, sys: 12.5 s, total: 2min 29s
Wall time: 2min 28s
miranov25 commented 1 year ago

First part of fix is working well Merging