miranov25 / RootInteractive

5 stars 12 forks source link

Minor histogram tutorial update and enabling spinnerRange for controlling aliases #270

Closed pl0xz0rz closed 1 year ago

pl0xz0rz commented 1 year ago

This PR:

miranov25 commented 1 year ago

There are some problems i some tests with current version:


----------------------------------------------------------------------------------------------- JSON report ------------------------------------------------------------------------------------------------
report saved to: test6.json
========================================================================================= short test summary info ==========================================================================================
FAILED test_bokehClientHistogramWeight.py::test_clientHistogramWeightCompressed - KeyError: 'Column index not found in data source None'
FAILED test_bokehClientHistogramWeight.py::test_clientHistogramWeight - KeyError: 'Column index not found in data source None'
=========================================================================== 2 failed, 35 passed, 7 warnings in 72.74s (0:01:12) ============================================================================

real    1m14.254s
user    9m36.252s
sys     0m35.120s
miranov25 commented 1 year ago

Comments to the customJsColumns.ipynb

Maybe add some tasks for user to make a modification: e.g add offset control to the custom function

miranov25 commented 1 year ago

UnitTest OK

-- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html
----------------------------------------------------------------------------------------------- JSON report ------------------------------------------------------------------------------------------------
report saved to: test6.json
================================================================================ 37 passed, 7 warnings in 79.31s (0:01:19) =================================================================================
miranov25 commented 1 year ago

OK. Merging.

Next, pull request to follow As we have already discussed, we need a new tutorial notebook for lossy and lossless compression. There we can already omit base64, which must always be used. The change should be backwards compatible