miranov25 / RootInteractive

5 stars 12 forks source link

makeJSCallback optimization and bugfixes #306

Closed pl0xz0rz closed 1 year ago

pl0xz0rz commented 1 year ago

This PR:

Fixes various bugs in makeJSCallback negatively affecting performance
- test_bokehClientHistogram.py - 5 widgets, 5e6 points, time for selecting points went from 300ms to 60ms
- ATO-609/trackClusterDumpDraw.ipynb - 3e6 points, 8 widgets, time for selecting points went from 240ms to 60ms
Fixes a bug with plot title when using custom axis titles
Fixes a crash that sometimes happens when downsampler is initialized (couldn't reliably reproduce)

miranov25 commented 1 year ago

Use case -ATO-624/tpcSpaceChargeQATime3D.ipynb -> spaceChargeDashboardMean3D.html

significantly faster 10 ms query for 500000 points

miranov25 commented 1 year ago

use case - ATO-614/interactiveToySimulOpt.ipynb OK

miranov25 commented 1 year ago

Test OK

================================================================================= 37 passed, 7 warnings in 90.06s (0:01:30) ==================================================================================

real    1m31.556s
user    22m51.092s
sys     1m12.596s