Predict rf stat - Githubissues

miranov25 / RootInteractive

5 stars 12 forks source link

Predict rf stat #323

Closed pl0xz0rz closed 1 year ago

pl0xz0rz commented 1 year ago

This PR: -Makes multiselect widget work with new pandas -Removes one liner utility functions from #320, performance of predictRFStat improved by further 10%

miranov25 commented 1 year ago

Did we have an issue created for the categorical multi-select pandas?

if yes -can you add it?
if not can you describe what you actually did?

miranov25 commented 1 year ago

Checking source code changes for categorical - is it related only to the output table, so it is only new feature?

miranov25 commented 1 year ago

We forgot to merge this request. Is this code compatible with the LinearRegression pull request?

pl0xz0rz commented 1 year ago

No, but manually merging it shouldn't be an issue, the only merge conflict should be a single line in the makeBokehMultiSelectSlider

EDIT: Seems I have accidentally managed to apply this PR's changes to the branch I used to make linear regression on the client

miranov25 commented 1 year ago

Fixed as side change in pull request #325