search

miranov25 / RootInteractive

5 stars 12 forks source link

Optimization for simple joins on client #344

Closed pl0xz0rz closed 10 months ago

pl0xz0rz commented 10 months ago

This PR partially fixes a bug with joins on client introduced in #326 that's making them slow by adding an early return

miranov25 commented 10 months ago

Tests are OK

-- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html -------------------------------------------------------------------------------------------------------------------------- JSON report --------------------------------------------------------------------------------------------------------------------------- report saved to: test6.json =========================================================================================================== 43 passed, 7 warnings in 133.74s (0:02:13)

miranov25 commented 10 months ago

Bug description as provided by @pl0xz0rz

The bug addressed in the pull request was simply that the code was running too slowly. The caching bug creates a problem wherein, if you have a custom selection widget, a multiselect varYNorm, and a changeable diff function (all three simultaneously), changing the diff function has no effect. To resolve this, you need to modify either varY or varYNorm.

miranov25 commented 10 months ago

Is it already a comprehensive fix, and is everything operating as you desire? Is there anything else that still requires attention?