search

miranov25 / RootInteractive

4 stars 12 forks source link

Bugfix for caching functions on the client used multiple times (introduced in #336, mentioned in #340) #346

Closed pl0xz0rz closed 7 months ago

pl0xz0rz commented 7 months ago

This PR fixes a bug introduced in #336 causing changing the diff function to not invalidate the cached values if the diff function is used in multiple places. This bug was already caught by a test, test_bokehClientHistogram.py::test_interactiveTemplateMultiYDiff

This PR also optimizes computing projections from histograms by preventing a sparse array from being created.

miranov25 commented 7 months ago

Hello @pl0xz0rz What was the speedup factor in the test with 5 million points? You can add it to the message

Marian

miranov25 commented 7 months ago

Test passed:

report saved to: test6.json ============================================================================================================= 43 passed, 7 warnings in 113.44s (0:01:53)

miranov25 commented 7 months ago

The latest version performs well in practical scenarios, with no identified issues.