miranov25 / fastMCKalman

Fast simulation and performance parameterization - primary for ALICE3 and DUNE
MIT License
0 stars 1 forks source link

Solved bug which produced extra point with same fX (local) after mirror in simulation. Before and after Mirror should still have the local fX i.e. same radius #11

Closed Trenchcoat95 closed 1 year ago

Trenchcoat95 commented 1 year ago

Tested with treeFast->Draw("gyMC:gxMC:(part.fParamMC[].fX==part.fParamMC[Iteration$-2].fX)","Iteration$>2","colz",10);

miranov25 commented 1 year ago

The seeding could be tested with seed streamer for fix https://github.com/miranov25/fastMCKalman/pull/11/commits/c6d40adcabd663b47037646694a177d44bc46b3d

miranov25 commented 1 year ago

Added protection against seeding in 2 mirror versions with fastTracker::makeYC, which is not obvious from the function name. This function is not used for seeding, but only to mark inconsistent (with the track model) seeding points. Aproprate documentation,add comment string to function.

miranov25 commented 1 year ago

In current pulll request there are still problems with incorrect triggering of PropagationToMirror Sometimes the track declaring it could be propagated (using GetXYZAtR) but not in reality.