miranov25 / fastMCKalman

Fast simulation and performance parameterization - primary for ALICE3 and DUNE
MIT License
0 stars 1 forks source link

Corrected calculation of sigmadE (sqrt not needed) #18

Closed Trenchcoat95 closed 2 years ago

Trenchcoat95 commented 2 years ago

Corrected mistake in sigmadE: sqrt not needed

New Pulls for the kalman filter reconstruction are a lot closer to 1: Info in : pullAnalytical - OK - 0.960927 Info in : pullAnalytical - OK - 1.005405 Info in : pullAnalytical - OK - 1.035221 Info in : pullAnalytical - OK - 1.007811 Error in : pullAnalytical- FAILED- 0.909541 Info in : pullAnalytical - OK - 0.983737 Info in : pullAnalytical - OK - 1.016043 Error in : pullAnalytical- FAILED- 1.060995 Info in : pullAnalytical - OK - 1.005980 Error in : pullAnalytical- FAILED- 0.933101

miranov25 commented 2 years ago

Original check presenteed in the: https://alice.its.cern.ch/jira/browse/PWGPP-613?focusedCommentId=292538&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-292538

Info in <testFastTracker part reco pull test P0 >: pullAnalytical - OK - 0.969439
Info in <testFastTracker part reco pull test P1 >: pullAnalytical - OK - 1.011373
Info in <testFastTracker part reco pull test P2 >: pullAnalytical - OK - 1.004920
Info in <testFastTracker part reco pull test P3 >: pullAnalytical - OK - 0.996542
Error in <testFastTracker part reco pull test P4>: pullAnalytical- FAILED- 0.779872
Info in <testFastTracker partFull reco pull test P0 >: pullAnalytical - OK - 0.994849
Info in <testFastTracker partFull reco pull test P1 >: pullAnalytical - OK - 1.025079
Info in <testFastTracker partFull reco pull test P2 >: pullAnalytical - OK - 1.051264
Info in <testFastTracker partFull reco pull test P3 >: pullAnalytical - OK - 1.013467
Error in <testFastTracker partFull reco pull test P4>: pullAnalytical- FAILED- 0.801984
Trenchcoat95 commented 2 years ago

New tests with the standard formatting:

Info in <testFastTracker part reco pull test P0 >: pullAnalytical - OK - 0.960927
Info in <testFastTracker part reco pull test P1 >: pullAnalytical - OK - 1.005405
Info in <testFastTracker part reco pull test P2 >: pullAnalytical - OK - 1.035221
Info in <testFastTracker part reco pull test P3 >: pullAnalytical - OK - 1.007811
Error in <testFastTracker part reco pull test P4>: pullAnalytical- FAILED- 0.909541
Info in <testFastTracker partFull reco pull test P0 >: pullAnalytical - OK - 0.983737
Info in <testFastTracker partFull reco pull test P1 >: pullAnalytical - OK - 1.016043
Error in <testFastTracker partFull reco pull test P2>: pullAnalytical- FAILED- 1.060995
Info in <testFastTracker partFull reco pull test P3 >: pullAnalytical - OK - 1.005980
Error in <testFastTracker partFull reco pull test P4>: pullAnalytical- FAILED- 0.933101
miranov25 commented 2 years ago

Resulting residuals - origin could be:

Trenchcoat95 commented 2 years ago

sigma as function of qpt: image

Trenchcoat95 commented 2 years ago

sqigma qpt as function of sinphi: image

miranov25 commented 2 years ago

Remaining discrepancy can be due to the difference in smearing - in covariance smearing relative in E and in MC in relative in p

miranov25 commented 2 years ago

Smearing will be still tuned later -working on the brag peak position fluctuation later ...